Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.0 Deployment #310

Merged
merged 12 commits into from
Dec 20, 2023
Merged

7.0 Deployment #310

merged 12 commits into from
Dec 20, 2023

Conversation

bhombot-ci[bot]
Copy link

@bhombot-ci bhombot-ci bot commented Dec 11, 2023

BHoMBot and others added 12 commits September 25, 2023 14:31
@BHoMBot
Upgrade AssemblyFileVersion to 7.0.0.0
b5412d7
Update AssemblyFileVersion to 7.0 (#307)
e75f202
@johannaisak @peterjamesnugent
Revert "Revert "Shear modulus and thermal coefficient value fix""
b526e28 
This reverts commit 85da751.
@johannaisak @peterjamesnugent
Revert "Revert "Revert "Shear modulus and thermal coefficient value f…
082e132 
…ix"""

This reverts commit bed84d1.
@TosteSkDa @peterjamesnugent
Added all functionality for reading, pushing and pulling rigid constr…
697c541 
…aints
@TosteSkDa @peterjamesnugent
Redefined how GSA_RigidConstraints are treated, now a part of Structu…
5f8b0a0 
…res_RigidLinks.

Rigid Constraints are now treated by BHoM as a Rigid Link object but with a fragment that if true tells GSA it is a Rigid Constraints. Removed previously added RigidConstraint Type and ENUM from this PR and instead adjusted the RigidLink methods. Also added more possible LinkConstraint options to the FromGsa - LinkConstraint method.
@peterjamesnugent
Fixed statement so links with multiple secondary nodes can be pushed
c2a79e5
@peterjamesnugent
Change delimitter for secondary nodes on RigidConstraints
871b3f8
@peterjamesnugent
Change fragment name to IsRigidConstraint to avoid confusion of GSARi…
a0e4ee9 
…gidConstraint based on previous comments
Pull and push Rigid constraints (#297)
2b9ac30
@BHoMBot
Update readme links and references
48c8b6b
Update README links and references (#309)
1fec57f
@FraserGreenroyd FraserGreenroyd added type:compliance Non-conforming to code guidelines type:feature New capability or enhancement and removed type:compliance Non-conforming to code guidelines labels Dec 11, 2023
@FraserGreenroyd FraserGreenroyd self-requested a review December 11, 2023 10:16
@Chrisshort92 Chrisshort92 self-requested a review December 20, 2023 15:08
Chrisshort92
Chrisshort92 approved these changes Dec 20, 2023
View reviewed changes
Copy link

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEst carried out by Artem Holstov with BH Eng artefact on 201223. Passed for merge. Some non-critical isseus to be resolved in future development. Issues logged in GitHub

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci BHoMBot-CI
Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 32 requests in the queue ahead of you.

@bhombot-ci BHoMBot-CI
Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Versioning_Toolkit

@bhombot-ci BHoMBot-CI
Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci BHoMBot-CI
Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check null-handling
  • check serialisation

There are 12 requests in the queue ahead of you.

FraserGreenroyd
FraserGreenroyd approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs have been reviewed by DevOps and are suitable for the deployment of develop to the 7.0 beta. Approving for merge.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core

@bhombot-ci BHoMBot-CI
Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@bhombot-ci BHoMBot-CI
Copy link
Author

bhombot-ci bot commented Dec 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd FraserGreenroyd merged commit 9e59a3b into main Dec 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chrisshort92 Chrisshort92 Chrisshort92 approved these changes

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

Assignees

@BHoMBot BHoMBot

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@FraserGreenroyd @Chrisshort92 @BHoMBot @johannaisak @TosteSkDa @peterjamesnugent